feat(ssi): add credential issuer and credential subject id validation rules #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolf4ood
force-pushed
the
feat/add_credential_validation_rules
branch
5 times, most recently
from
d4e0ec2 to
e04a2ea
Compare
charts/tractusx-connector/templates/deployment-controlplane.yaml
Outdated
Show resolved
Hide resolved
...c/main/java/org/eclipse/tractusx/edc/iam/ssi/miw/rule/SsiCredentialIssuerValidationRule.java
Show resolved
Hide resolved
...ain/java/org/eclipse/tractusx/edc/iam/ssi/miw/rule/SsiCredentialSubjectIdValidationRule.java
Show resolved
Hide resolved
...nt/src/test/java/org/eclipse/tractusx/edc/iam/ssi/miw/SsiMiwValidationRuleExtensionTest.java
Outdated
Show resolved
Hide resolved
...nt/src/test/java/org/eclipse/tractusx/edc/iam/ssi/miw/SsiMiwValidationRuleExtensionTest.java
Outdated
Show resolved
Hide resolved
...st/java/org/eclipse/tractusx/edc/iam/ssi/miw/rule/SsiCredentialIssuerValidationRuleTest.java
Show resolved
Hide resolved
wolf4ood
force-pushed
the
feat/add_credential_validation_rules
branch
3 times, most recently
from
c21c250 to
24eeffe
Compare
wolf4ood
force-pushed
the
feat/add_credential_validation_rules
branch
3 times, most recently
from
c5b31c7 to
913fc87
Compare
wolf4ood
force-pushed
the
feat/add_credential_validation_rules
branch
from
913fc87 to
1631ab7
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
paullatzelsperger
approved these changes
Jul 4, 2023
ndr-brt
approved these changes
Jul 4, 2023
paullatzelsperger
pushed a commit
that referenced
this pull request
Jul 4, 2023
… rules (#548) * feat(Ssi): add credential issuer and credential subject id validation rules * fix after review * fix helm tests
paullatzelsperger
pushed a commit
to paullatzelsperger/tractusx-edc
that referenced
this pull request
Jul 4, 2023
… rules (eclipse-tractusx#548) * feat(Ssi): add credential issuer and credential subject id validation rules * fix after review * fix helm tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Adds two more validation rule in the validation pipeline:
SsiCredentialIssuerValidationRulechecks that the issuer of the credential matches the configured one.SsiCredentialSubjectIdValidationRulechecks that the issuer of the VP matches the credential subject id of the VCWHY
Probably those checks are duplicated with MIW, but in case we also would want to check that on our side.
By default the
authorityIssueris composed with `did:web::